chore: Pin python version to fix aiohttp regression tests#788
Merged
ShogunPanda merged 1 commit intonodejs:mainfrom Feb 24, 2026
Merged
chore: Pin python version to fix aiohttp regression tests#788ShogunPanda merged 1 commit intonodejs:mainfrom
ShogunPanda merged 1 commit intonodejs:mainfrom
Conversation
ShogunPanda
approved these changes
Feb 24, 2026
Contributor
|
FYI, I changed this to 3.x previously when people were confused why the tests stopped working, because it was pinned to an old version that we dropped support for. As we support the latest version of Python, such breakages should be rare. In this case, there was a security release to 3.14 that caused one of our tests to start failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests fail due to a Python version vs Aiohttp dependency incompatibility in Python 3.14+, which breaks the initial Aiohttp project setup. From our side though, I think there's no issue with simply testing with Python 3.13 anyway, and having a pinned version gives more reproducible tests, so it's actually quite helpful in itself.